On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger <jgn...@openjdk.org> wrote:
> Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. This pull request makes three changes: 1. The ISO 8601 extended format of the build date and time is now used only in the `--date` option of the `jmod` command, as required. The historical custom format of `"yyyy-MM-dd-HHmmss"` is used everywhere else for the build timestamp. 2. The build file's short and long version strings, `RELEASE_VERSION_SHORT` and `RELEASE_VERSION_LONG`, are now added directly to the `VersionInfo.java` template file for use as the run-time values of the system properties `javafx.version` and `javafx.runtime.version`. This change prevents the values from getting out of sync again between their build-time and run-time values.. 3. Four test cases are added to `VersionInfoTest.java`. Two of the tests verify that the JavaFX version and run-time version have the correct format. The other two tests verify that their values at run time are equal to their values in the static file `javafx.properties` created at build time and found in the JavaFX SDK and in the `javafx.base` modular JAR file. These test cases prevent this error from happening again. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1253#issuecomment-1746955577
