On Sat, 28 Oct 2023 18:21:52 GMT, Kevin Rushforth <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> jcheck
>
> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 6352:
>
>> 6350: parent = ((Stage)window).getOwner();
>> 6351: } else if (window instanceof
>> com.sun.javafx.embed.EmbeddedSceneInterface) {
>> 6352: return
>> ((com.sun.javafx.embed.EmbeddedStageInterface)window).getNodeOrientation();
>
> This is the right idea, but the wrong type. The window, which is a
> `javafx.scene.Window` will never be an instance of `EmbeddedSceneInterface`
> which is a `GlassStage` peer. In the case of `JFXPanel`, the window will be a
> `com.sun.javafx.stage.EmbeddedWindow`.
I meant "...never an instance of `EmbeddedStageInterface`"
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1271#discussion_r1375314412
