On Sat, 28 Oct 2023 03:57:05 GMT, Michael Strauß <[email protected]> wrote:
>> Florian Kirmaier has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origjfx/master' into
>> JDK-8269921-textflow-bug
>> - JDK-8269921
>> Reverted the change to the layout, so we can fix the main-bug without
>> further discussions.
>> - Merge remote-tracking branch 'origjfx/master' into
>> JDK-8269921-textflow-bug
>> - JDK-8269921
>> Added a copyright header
>> - JDK-8269921
>> Fixing a crash related to Text and TextFlow with bounds listeners
>
> tests/system/src/test/java/test/javafx/scene/text/TextFlowCrashTest.java line
> 27:
>
>> 25: package test.javafx.scene.text;
>> 26:
>> 27: import org.junit.BeforeClass;
>
> Can you update this class to use JUnit5?
Updated to junit5!
> tests/system/src/test/java/test/javafx/scene/text/TextFlowCrashTest.java line
> 108:
>
>> 106: }
>> 107:
>> 108: public void onEveryNode(Node node) {
>
> The name of this method doesn't seem to describe what it does. It seems to do
> very little.
I've improved the name of the method!
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/564#discussion_r1376366510
PR Review Comment: https://git.openjdk.org/jfx/pull/564#discussion_r1376366734
