On Thu, 2 Nov 2023 08:16:43 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> Before, the `updateItem` method was called with the new value that was >> committed via `commitEdit()`. >> This is problematic as developers may setup a commit handler via >> `setOnEditCommit`, which may reject the edit (or change the value otherwise). >> We therefore do call the `updateItem(-1)` which will also call `updateItem` >> but with the real underlying value. >> >> Changed and added tests for all 4 cells. > > Marius Hanl has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge remote-tracking branch 'origin/master' into 8187314-cell-backing-data > - JDK-8187314: All Cells: must show backing data always > TreeTableView with multiple columns works as expected. Thanks for checking. In the meantime I also checked out the tests, and all of them do test one column (`startEdit`, `cancelEdit`, `commitEdit`, `setOnEditCommit`, ....), so I really think we are good here! 🙂 ------------- PR Comment: https://git.openjdk.org/jfx/pull/1197#issuecomment-1790268360
