On Wed, 11 Oct 2023 11:18:17 GMT, Jayathirth D V <j...@openjdk.org> wrote:
>> Two perspective lod tests fail because of minute differences in expected >> values. >> >> Failing tests: >> test/scenegraph/fx3d/lod/PerspectiveLodCameraTest.java: >> test/scenegraph/fx3d/lod/PerspectiveLodGroupTest.java: >> >> Exception: >> test test.scenegraph.fx3d.lod.LodTests.sphereInitialLightOnTest(): failure >> org.jemmy.TimeoutExpiredException: State 'Expected 50180.140882730484, but >> was 50180.137157440186' has not been reached in 1000 milliseconds >> at org.jemmy.timing.Waiter.ensureValue(Waiter.java:93) >> at test.scenegraph.fx3d.lod.LodTestBase.checkLod(LodTestBase.java:117) >> at >> test.scenegraph.fx3d.lod.LodTests.sphereInitialLightOnTest(LodTests.java:98) >> at >> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) >> at java.base/java.lang.reflect.Method.invoke(Method.java:577) >> at >> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) >> at >> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) >> at >> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) >> at >> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) >> at >> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) >> at >> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) >> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) >> at java.base/java.lang.Thread.run(Thread.java:833) >> >> These little difference in values are seen both initial drawing and updates. >> These tests are not run from long time and change in product might change >> lod values. >> >> With updated lod values i have verified that both the tests pass in OpenGL >> and Metal pipeline with both retina display(scale = 2) and external >> monitor(scale = 1). > > Jayathirth D V has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Merge remote-tracking branch 'upstream/master' into lod_tests > - Add lod tolerance > - 8315896: Perspective lod tests fail because of minute difference in values Looks good. Please file a follow-up bug to get the tests running on Windows. ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx-tests/pull/6#pullrequestreview-1710342446
