On Thu, 9 Nov 2023 22:07:34 GMT, Jose Pereda <jper...@openjdk.org> wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use only 10 cycles instead of 50 (preventing this test to take 50 seconds
>> in case it fails).
>
> tests/system/src/test/java/test/javafx/stage/SystemMenuBarTest.java line 148:
>
>> 146: stage.show();
>> 147: stage.requestFocus();
>> 148: Thread t = new Thread(){
>
> minor, use `new Thread(() -> {...});`(or else add a whitespace before the
> curly brace: `new Thread() {`)
I'll go with the whitespace then, as I find it much more clear to explicitly
construct, assign, and start a thread.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1277#discussion_r1389194261
