On Thu, 2 Nov 2023 11:55:46 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/DatePickerOnFocusLostTest.java
>> line 98:
>>
>>> 96: // 3. Click on button to grab the focus and hence attempt to
>>> datePicker.commitValue()
>>> 97: // 4. Verify that in case of typo, the value was reverted, as well
>>> as the editor's text
>>> 98: public void testDatePickerCommit(boolean typo) throws Exception {
>>
>> you actually can also write a normal JUnit test as far as I get this. Then
>> there is no need for `Util.runAndWait`, `sleep` and so on.
>>
>> See: `test.javafx.scene.control.DatePickerTest`
>
> A headless test is the preferred way to do it, if feasible. If it is, move
> the test to the `javafx.controls` module.
I have removed the robot test, and replaced it by a simple test case in the
existing class `DatePickerTest` in `javafx.controls`
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1274#discussion_r1389638701
