On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox <m...@openjdk.org> wrote:
> The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at > least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent > alters its state in some way that confuses NSTextInputContext.handleEvent. > The result is that all key events are discarded if an IME is active. Apple > fixed this bug in macOS 14 Sonoma. > > In this PR we switch to using the same Carbon call that we started using in > PR #425 (jfx21) to query the keyboard layout. > > This is a new implementation of the fix for > [JDK-8087700](https://bugs.openjdk.org/browse/JDK-8087700) so that bug will > need to be re-tested. Changes look good to me. I've tested: - M1/macOS 14.1.1 (no issues before or after this PR) - Intel/macOS 12.6.6 (reported issues starting 22-ea+18, and no issues after this PR) ------------- Marked as reviewed by jpereda (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1295#pullrequestreview-1754151600
