On Tue, 14 Nov 2023 10:24:20 GMT, Karthik P K <k...@openjdk.org> wrote:

> The change listener on caretPositionProperty() was not getting invoked on 
> replacing the content with same text as there was no change in caret 
> position. Since the textProperty invalidation sets the forward bias to true 
> by default, incorrect caret position was  calculated when the same text was 
> replaced after clicking on the trailing edge of last character or empty space 
> in the TextField.
> 
> Since caretShapeProperty invalidation listener gets invoked without changing 
> the caret position, updating the caretBiasProperty on this listener solves 
> the issue.
> 
> Since the caret position value will be same when the caret is present after 
> the last character or before the last character, it can not be validated 
> using unit test.
> The fix can be validated using MonkeyTester.
> Steps to select TextField option in Monkey Tester.
> 
> - Open the MonkeyTester app and select TextField from the left option pane.
> - Select Short from Text selection option and click on the TextField to bring 
> it into focus.
> - Select all using cmd(ctrl) + a and copy using cmd(ctrl) + c
> - Click on empty space in the TextField after the present content.
> - Select all again using the keyboard shortcut and paste using cmd(ctrl) + v
> - The caret should be displayed after the last character. Without the fix 
> caret gets displayed before the last character.

This pull request has now been integrated.

Changeset: 2108ecf9
Author:    Karthik P K <k...@openjdk.org>
URL:       
https://git.openjdk.org/jfx/commit/2108ecf9d7c8c459964a9e8b5e37485b3507b028
Stats:     5 lines in 1 file changed: 3 ins; 0 del; 2 mod

8282290: TextField Cursor Position one off
8248914: Javafx TextField positions the cursor incorrectly after pressing DEL 
key

Reviewed-by: angorya, mhanl

-------------

PR: https://git.openjdk.org/jfx/pull/1287

Reply via email to