On Thu, 7 Dec 2023 18:30:24 GMT, Michael Strauß <mstra...@openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/application/WindowsHighContrastScheme.java
>>  line 43:
>> 
>>> 41:  * The high contrast feature may not be available on all platforms.
>>> 42:  */
>>> 43: enum WindowsHighContrastScheme {
>> 
>> I'd rather keep the old name: `HighContrastScheme`: It is in a non-platform 
>> specific package, and it applies to all platforms (even only with `NONE`).
>> You could add a comment about `HIGH_CONTRAST_*` enum constants being only 
>> available on Windows.
>
> But it never applied to all platforms, it reflects exactly the Windows 
> implementation of high-contrast schemes. It will be moved once we add style 
> themes.

ok

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1014#discussion_r1419477427

Reply via email to