On Wed, 17 Jan 2024 17:13:11 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/native-glass/gtk/glass_window_ime.cpp line >> 163: >> >>> 161: g_signal_connect(im_ctx.ctx, "preedit-changed", >>> G_CALLBACK(on_preedit_changed), this); >>> 162: g_signal_connect(im_ctx.ctx, "preedit-end", >>> G_CALLBACK(on_preedit_end), this); >>> 163: g_signal_connect(im_ctx.ctx, "commit", G_CALLBACK(on_commit), >>> this); >> >> On Ubuntu 22.04 using the Japanese (Mozc) input method I get a bunch of >> debug output from IBus. The message reads >> >> `IBUS-WARNING **: 08:50:12.994: java has no capability of surrounding-text >> feature` >> >> I was able to silence this by connecting to the surrounding text signal and >> simply returning TRUE from the callback. > > Fixed, although JavaFX does not support it, so the warning is true. Looks good to me. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1080#discussion_r1466766895
