On Thu, 25 Jan 2024 15:46:24 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Minor corrections as per review comments > > modules/javafx.web/src/main/native/Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp > line 197: > >> 195: continue; >> 196: placeholdersToRestore.append(&placeholder); >> 197: } > > The added curly braces should be within `#if PLATFORM(JAVA)`. > > Minor: the indentation is off in a couple places. > > Minor: add a missing space after the `if` on line 191. > > Here is a suggestion: > > > #if PLATFORM(JAVA) > if (spannerAndPlaceholder.value.get() != nullptr) > { > #endif > if (!placeholder.isDescendantOf(&container)) > continue; > placeholdersToRestore.append(&placeholder); > #if PLATFORM(JAVA) > } > #endif done ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1350#discussion_r1467705618