On Thu, 8 Feb 2024 18:13:58 GMT, Andy Goryachev <[email protected]> wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix emoji issue
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java
> line 531:
>
>> 529: for (int i = runs.length - 1; i > runIdx; i--) {
>> 530: TextRun r = runs[i];
>> 531: boolean addLtrIdx =
>> run.getTextSpan().getText().length() != run.length;
>
> Q: we should never get an NPE here, correct?
Yes we will not get NPE here. We enter this block only when `spans != null` so
I don't think we need another null check here.
We have one null check at l.no.515 which is not really necessary but I will
keep it as it is for now.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1323#discussion_r1483973542
