On Mon, 19 Feb 2024 10:21:52 GMT, Karthik P K <k...@openjdk.org> wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/RTLTextCharacterIndexTest.java
>> line 107:
>>
>>> 105: */
>>> 106:
>>> 107: public class RTLTextCharacterIndexTest {
>>
>> This is a system test, which don't run with the build system. Are you sure
>> this will work on all platforms? I don't see a specific `Font` used, which
>> means `X_LEADING_OFFSET` may be incorrect when the platform is supplying a
>> different font.
>
> I see that the tests don't run on all the platforms. I will look into this
> and update the PR
A valid concern about specific fonts, similar to
https://github.com/openjdk/jfx/pull/1236#issuecomment-1937022815
What was the resolution there? To use a hard-coded font based on the platform,
or pick an available one from the list?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1323#discussion_r1496062620
