On Thu, 22 Feb 2024 20:38:00 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass > `Material`). Except for the introduction, I divided the documentation into 3 > sections: qualitative explanation, mathematical model (I wouldn't think it > necessary, but the current doc explains it), and examples. > > The reason for the verbosity of the doc is that I envisioned 2 target > audiences for this class. One is a Java developer who wants to understand the > terminology and workings of computer graphics or of the artists who are > already familiar with this domain. (How many Java developers know what > diffuse, specular and normal maps are?) The other is an artist who is already > familiar with the domain, but wants to see how this class compares with other > renderers. For this reason, I looked at the terminology used by engines like > Blender, Maya, UE4 and Unity and tried to mention the comparisons (like bump > vs. height vs. normal maps, or specular vs. roughness/smoothness). > > The examples I chose and some of the schematics are not the best, looking at > it retroactively, but I want to give enough time for reviewers and get this > into 22. modules/javafx.graphics/src/main/docs/javafx/scene/paint/doc-files/color and map/map.png line 1: > (failed to retrieve contents of file, check the PR for context) Is this a licensed image? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1378#discussion_r1499917718