On Thu, 22 Feb 2024 15:41:55 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> @Maran23 I see from the description that you tested this on mac. How did you > test it? Did you run with `-PFULL_TEST=true`? No, I checked the example in the ticket as well as the handling of dialogs in general on Mac. Unfortuantely, I always need to ask a colleague to test my JavaFX Builds on Mac, but maybe it's time to setup a VM on my Windows machine. Are there any recommendations I may should follow for the setup? :-) Regarding the system tests, I checked the nested event loop ones on Windows and they work for me. I just pushed a change which may fixes this for Mac as well. The change is also logical and is synchronized with the other changes I made to nested event loops. Will ask my colleague as well to test my changes again + run the most obvious (related) system tests on Mac. I also will do a much bigger testing soon, I have an application that relies heavily on nested event loops for blocking the UI while doing background work. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1324#issuecomment-1960498210
