On Sat, 17 Feb 2024 18:11:09 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> Platform preferences detection doesn't pick up effective macOS system >> preferences if AWT owns the NSApplication and has set its NSAppearance to a >> fixed value. >> >> The workaround is to set the system property >> "apple.awt.application.appearance=system". >> >> If this property is not set, the following warning will be emitted if a >> JavaFX application attempts to use the platform preferences API: >> >> >> WARNING: Reported preferences may not reflect the macOS system preferences >> unless the sytem >> property apple.awt.application.appearance=system is set. This warning can be >> disabled by >> setting javafx.preferences.suppressAppleAwtWarning=true. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > address review comments Looks good with one minor formatting suggestion (but I'll approve it as is). modules/javafx.graphics/src/main/java/com/sun/glass/ui/mac/MacApplication.java line 483: > 481: > 482: if (!AWT_SYSTEM_APPEARANCE.equals(awtAppearanceProperty)) { > 483: Logging.getJavaFXLogger().warning(String.format( Minor: Maybe add newlines to break this message into two or three separate lines? ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1367#pullrequestreview-1898861689 PR Review Comment: https://git.openjdk.org/jfx/pull/1367#discussion_r1501125311