On Thu, 29 Feb 2024 17:33:14 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> @hjohn how do you get this coverage diagram? >> >> The BreakIterator is a part of the existing code, we should probably have >> this discussion outside of this PR. I agree, there might be a situation >> when the app wants to select a specific locale for the text component >> instead of relying on the default locale. > > @andy-goryachev-oracle The coverage comes from EclEmma, an Eclipse plugin. > Once installed, there is another way to run tests called `Coverage as...` > just above `Run as...`. It's very useful to use it on a JUnit test to see if > there are major branches you missed in testing that may require additional > cases. thank you @hjohn good to know about EclEmma you might be right about dead code: I could not hit the break points in L461 or L471 with the MT. There might be a scenario which we are not testing. I'd say leave it as is perhaps? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1323#discussion_r1508028426
