On Fri, 1 Mar 2024 03:49:20 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 142: > >> 140: * future Swing or JavaFX releases. The current serialization support is >> 141: * appropriate for short term storage or RMI between applications >> running >> 142: * the same version of Swing and the same version of JavaFX. > > Shouldn;t we need to add > @SuppressWarnings("serial") // Same-version serialization only > > which I see in almost all classes in Swing which has the above serialization > warning... This PR is addressing doclint warnings, not javac lint warnings. javac warnings can be addressed in a follow-up bug. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1386#discussion_r1508960125