On Sun, 3 Mar 2024 22:29:02 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
> Update for the 3D lighting test tool as described in the JBS issue.
Couple quick comments:
- Executing the LightingSample manually fails with an exception
Caused by: java.lang.NullPointerException: Input stream must not be null
at
javafx.graphics@23-internal/javafx.scene.image.Image.validateInputStream(Image.java:1140)
at
javafx.graphics@23-internal/javafx.scene.image.Image.<init>(Image.java:707)
at lighting3D.Environment.<clinit>(Environment.java:64)
Steps:
cd tests/performance/3DLighting/src/main/java
javac <compile.args> lighting3D/*.java
java <run.args> lighting3D.LightingApplication
- The copyright year new files should be 2024 only. Some new files have more
than one copyright year. If you are moving any existing files then please use
`git mv` so that the files are shown as moved.
- Some files are missing copyright headers.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1387#issuecomment-1979195208
