On Tue, 12 Mar 2024 14:45:06 GMT, Hima Bindu Meda <hm...@openjdk.org> wrote:
> Updated icu to v74.2. Sanity testing looks fine. Verified build on all > platforms I haven't looked at it detail or tested it yet, but I did spot one thing that raises a question. @johanvos or @tiainen can one of you be the second reviewer? modules/javafx.web/src/main/native/Source/ThirdParty/icu/CMakeLists.txt line 593: > 591: > 592: # Get just file name without extension > 593: set(ICU_DATA_FILE_NAME "icudt74l") Shouldn't this be 742? ------------- PR Review: https://git.openjdk.org/jfx/pull/1398#pullrequestreview-1931321499 PR Comment: https://git.openjdk.org/jfx/pull/1398#issuecomment-1991854992 PR Review Comment: https://git.openjdk.org/jfx/pull/1398#discussion_r1521623658
