On Wed, 13 Mar 2024 16:30:27 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> Karthik P K has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Review comments
>
> tests/system/src/test/java/test/robot/javafx/scene/RTLTextFlowCharacterIndexTest.java
>  line 116:
> 
>> 114:     static volatile Scene scene;
>> 115: 
>> 116:     static final int WIDTH = 600;
> 
> one suggestion: maybe we can reduce the font size from 48 to something 
> smaller.
> that might also speed up the test as the cursor wouldn't have to traverse a 
> lot of pixels.  watch out for change in line breaks though.

Thanks for suggesting this @andy-goryachev-oracle. I have made the changes in 
the test. I reduced the font size little bit only to make sure that the 
multiline text are not displayed in a single line.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1399#discussion_r1524832327

Reply via email to