On Thu, 21 Mar 2024 13:40:37 GMT, Karthik P K <[email protected]> wrote:
>> Enabled a test in `SpinnerTest` class.
>> Added comment to the editing test, why it can not be enabled. When Spinner
>> value is set using `getEditor` `setText` method, the listener added to the
>> spinner is not invoked. There is no bug for this issue. I'm not sure about
>> the expectation in this case.
>> Other set of tests which are ignored are `LocalTimeSpinnerValueFactory`
>> tests. Since these tests are unstable and fail only at certain time of the
>> day, not enabling this test as well.
>
> Karthik P K has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add bug id to ignore comment
modules/javafx.controls/src/test/java/test/javafx/scene/control/SpinnerTest.java
line 341:
> 339:
> **************************************************************************/
> 340:
> 341: @Ignore("JDK-8328701")
the spinner is not editable and no commitValue() is issued (please see my
comment in the ticket)
https://bugs.openjdk.org/browse/JDK-8328701?focusedId=14659352&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14659352
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1414#discussion_r1534088412
