On Sat, 16 Mar 2024 15:47:18 GMT, Marius Hanl <mh...@openjdk.org> wrote:
> This PR fixes the issue that the initial column autosizing is wrong under > some circumstances. > The following things will break the initial autosizing: > - Bold Column text (that is where I initially found this problem) > - Another font / font size > - Graphic > - Graphic Content Display (which can be styled via CSS) > > The reason is actually quite simple: The CSS is not (yet) applied initially, > we therefore ALWAYS take the default font into account + the graphic is not > yet layouted as well. > > ~It was not so easy to write tests for this, also for me the > `test_resizeColumnToFitContentHeader` is always failing locally. I don't know > what happens here, but he seems to not find a (Stub?) `Font` for me.~ > **EDIT: Found out the cause and fixed it. I will check if I can write more > tests since it works now. :)** > > The test I wrote now is checking if the css is applied after we triggered the > autosize, which is what we would expect here since we measure text. > > I also copied the `TableColumnHeaderTest` and rewrote the tests for > `TreeTableView` as well, so we can catch any errors here as well since they > both use different code (although it is technically the same - C&P errors can > happen very easy). This pull request has now been integrated. Changeset: 44d53baf Author: Marius Hanl <mh...@openjdk.org> URL: https://git.openjdk.org/jfx/commit/44d53baf2f9fda395e6a37671794482d7f0a28ca Stats: 515 lines in 4 files changed: 505 ins; 4 del; 6 mod 8186188: TableColumHeader: initial auto-size broken if has graphic Reviewed-by: angorya, rlichten ------------- PR: https://git.openjdk.org/jfx/pull/1405
