On Mon, 12 Feb 2024 10:00:57 GMT, Karthik P K <k...@openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change test to use the more common Arial font and add assumptions
>
> I ran the tests in my Mac system with macOS 14.3 and found 2 tests are
> failing with following error:
>
>
> TextLayoutTest > caseTest(Case) >
> test.com.sun.javafx.text.TextLayoutTest.caseTest(Case)[10] FAILED
> org.opentest4j.AssertionFailedError: left aligned rich text (spans): line
> 0 for Parameters[text=The quick brown लोमड़ी jumps over the lazy कुत्ता,
> wrapWidth=160.0, lineWidths=[158.1914, 93.134766]] ==> expected: <RectBounds
> { minX:0.0, minY:-10.863281, maxX:158.1914, maxY:2.9355469} (w:158.1914,
> h:13.798828)> but was: <RectBounds { minX:0.0, minY:-10.863281,
> maxX:155.3047, maxY:2.9355469} (w:155.3047, h:13.798828)>
> at
> app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
> at
> app//org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
> at
> app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
> at
> app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1152)
> at
> app//test.com.sun.javafx.text.TextLayoutTest.caseTest(TextLayoutTest.java:501)
>
> TextLayoutTest > caseTest(Case) >
> test.com.sun.javafx.text.TextLayoutTest.caseTest(Case)[11] FAILED
> org.opentest4j.AssertionFailedError: left aligned rich text (spans): line
> 0 for Parameters[text=The quick brown लोमड़ी jumps over the lazy
> कुत्ता, wrapWidth=160.0, lineWidths=[158.1914, 93.134766]] ==> expected:
> <RectBounds { minX:0.0, minY:-10.863281, maxX:158.1914, maxY:2.9355469}
> (w:158.1914, h:13.798828)> but was: <RectBounds { minX:0.0, minY:-10.863281,
> maxX:155.3047, maxY:2.9355469} (w:155.3047, h:13.798828)>
> at
> app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
> at
> app//org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
> at
> app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
> at
> app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1152)
> at
> app//test.com.sun.javafx.text.TextLayoutTest.caseTest(TextLayoutTest.java:501)
>
> TextLayoutTest > fixedComplexTestsToEnsureNoFurtherRegressions() SKIPPED
>
> TextLayoutTest > complexTestsThatAreBrokenSince2013() SKIPPED
>
>
> The failing tests are SOFT_WRAP_WITH_COMPLEX_TEXT and
> SOFT_WRAP_WITH_COMPLEX_TEXT_AND_EXTRA_SPACE.
>
> Added a minor comment inline as well.
@karthikpandelu @kevinrushforth @andy-goryachev-oracle
I split the failing Mac tests into Windows and Mac variants. However, the Mac
specific tests probably still fail. If one of you could post the test errors, I
can fix the values used as I don't have a Mac to test on.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1236#issuecomment-2071440980
