On Sat, 13 Apr 2024 01:36:01 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
> - When video fails to render AVFoundation outputs frame in > `kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange` format which is not > supported. We do force format change after that to > `kCVPixelFormatType_422YpCbCr8`, but AVFoundation does not provides any video > frames after format change. Not sure why it happens. > - When video worked for stream in this issue, then AVFoundation was using > `kCVPixelFormatType_422YpCbCr8` for some reason instead of > `kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange`. > - I tested format fallback from > `kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange` to > `kCVPixelFormatType_422YpCbCr8` manually and many streams I tried works fine, > except one reported in this bug. > - If AVFoundation is initialized with list of formats JavaFX Media rendering > supports, then this issue is no longer reproducible. > - Fixed by providing list of supported formats to AVFoundation. > - Removed unused variable `response`. > - Tested with all streams I have and no issues found. Looks good. ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/1440#pullrequestreview-2021055321
