On Thu, 25 Apr 2024 06:37:00 GMT, Oliver Kopp <d...@openjdk.org> wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462. >> >> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, >> then an addition of `start` to it leads to a negative value. This is "fixed" >> by using `Math.max` comparing the `maxLength` and `maxLength + start`. > > Oliver Kopp has updated the pull request incrementally with one additional > commit since the last revision: > > Switch from `@EnabledOnOS` to `assumeTrue` Ok, let's try to narrow down the issue, using the sample TextAreaTest_Narrator_8330462 (it does not matter whether we have a TextArea or a TextField there). In the master branch, with the Narrator (N.) enabled, the first thing I see it that the whole text is highlighted and the N. reads it. When the user navigates using left/right arrow keys, the N. focus rectangle follows the windows cursor and announces the letter at the cursor. With the fix, the windows cursor moves, but the N. rectangle does not move, and that is the issue. Do you see the same with and without your fix (making sure you do a clean build when switching branches)? ------------- PR Comment: https://git.openjdk.org/jfx/pull/1442#issuecomment-2077857093
