On Thu, 9 May 2024 09:04:54 GMT, Johan Vos <j...@openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511: Use viewport length as block increment
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
> line 1808:
>
>> 1806: * @return the value in pixels
>> 1807: */
>> 1808: public double getBlockIncrement() {
>
> I'd rather not add that method but instead make `getViewportLength()` public.
> That would benefit other use cases, and it is more behavior-agnostic. The
> "viewportLength" is easier to define in a contract than a "blockIncrement"
> and since this is exactly what you return, it sounds like a reasonable thing
> to do.
Good suggestion. I have made the necessary changes.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1326#discussion_r1595238708
