On Fri, 19 Apr 2024 20:36:42 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> This change replaces Character.isLetterOrDigit(char) which fails with >> surrogate characters with Character.isLetterOrDigit(int). > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into 8330590.prev.word > - 8330590 TextInputControl: previous word fails with Bhojpuri characters Fix looks good, providing minor comments. modules/javafx.controls/src/main/java/javafx/scene/control/TextInputControl.java line 1745: > 1743: } > 1744: > 1745: private static boolean isLetterOrDigit(String text, int ix, int > len) { The `len` variable is unused in this method. modules/javafx.controls/src/main/java/javafx/scene/control/TextInputControl.java line 1751: > 1749: } else if (ix >= text.length()) { > 1750: return false; > 1751: } May be combine them into single if statement. Or may be remove the checks as this is a private method. ------------- Changes requested by arapte (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1444#pullrequestreview-2062693079 PR Review Comment: https://git.openjdk.org/jfx/pull/1444#discussion_r1604573811 PR Review Comment: https://git.openjdk.org/jfx/pull/1444#discussion_r1604573300