On Mon, 20 May 2024 23:37:22 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Adding alt-ctrl-LEFT/RIGHT/UP/DOWN (option-command-LEFT/RIGHT/UP/DOWN) key >> bindings to >> >> - ListView >> - TreeView >> - TableView >> - TreeTableView >> >> to support keyboard-only horizontal and vertical scrolling. The main reason >> for the change is to improve accessibility. >> >> **NOTE: For controls in right-to-left orientation, the direction of >> horizontal scrolling is reversed.** >> >> As far as I can tell, these key combinations do not interfere with editing. >> >> The proposed solution can be further optimized by adding a public method to >> the VirtualFlow class, something like >> >> >> public void horizontalUnitScroll(boolean right); >> public void verticalUnitScroll(boolean down); >> >> >> Q: Does this change require a CSR to explain the change in the controls' >> behavior? We don't yet have the key bindings documented in >> /doc-files/behavior >> >> Note: >> Jenkins headful test passed on all mac configurations, failed on all linux >> configurations (master branch failed also, so it is test issue), while >> windows configuration is not yet available. > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 19 additional > commits since the last revision: > > - review comments > - Merge branch 'master' into 8313138.horizontal > - vertical scrolling tests > - added vertical scrolling > - Merge branch 'master' into 8313138.horizontal > - tests > - cleanup > - node orientation > - Merge remote-tracking branch 'origin/master' into 8313138.horizontal > - table view behavior > - ... and 9 more: https://git.openjdk.org/jfx/compare/b36355cd...5ec3c27e Marked as reviewed by arapte (Reviewer). ------------- PR Review: https://git.openjdk.org/jfx/pull/1393#pullrequestreview-2068661942
