On Sat, 25 May 2024 13:50:56 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> The code looks good. I didn't test it, but I'm fine with integrating. > >> Also some clarification on the contributing rules: "all Reviewers who have >> requested the chance to review have done so" -- does the indication at the >> top right of the PR count towards this or should it be a comment? :) In the >> first case, @nlisker and @arapte, please indicate if you wish to review this >> still. > > If someone wants you to wait for them, they should make it clear by adding a > comment. Also if someone has given substantive feedback, but hasn't > (re)approved, it's good to give them a change to review. > > @arapte can add a comment if he wants to review, otherwise go ahead and > integrate on Monday. @kevinrushforth @andy-goryachev-oracle @Maran23 @mstr2 I couldn't leave this without a proper test, so I created a test for `FixedCapacitySet`. I didn't discover any issues, but did discover there was a line of code I couldn't cover in the `OpenAddressed` variant (not even with a specially crafted test case). I checked the code, and realized the situation can never occur, so I've removed those lines and added a comment and `assert` instead. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1316#issuecomment-2134343376
