On Thu, 6 Jun 2024 14:59:04 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixing the issue in CTGlyphLayout class > > modules/javafx.graphics/src/main/java/com/sun/javafx/font/coretext/CTGlyphLayout.java > line 161: > >> 159: * When traling spces are present in the text containing >> LTR and RTL >> 160: * text together, negative position values are returned for >> spaces from >> 161: * the native side. Since TextRun expects positive value >> relative to the > > should we limit the scope of the change to mac only (PlatformUtil.isMac()?) > since CTGlyphLayout is common code? CTGlyphLayout is not common code. It is mac only (so no need to mention mac) ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1468#discussion_r1629745180
