On Tue, 25 Jun 2024 22:48:26 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> Markus Mack has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - cleanup imports >> - add clarifying comment to test > > modules/javafx.controls/src/test/java/test/javafx/scene/chart/XYNumberLineChartsTest.java > line 30: > >> 28: import javafx.scene.shape.MoveTo; >> 29: import javafx.scene.shape.Path; >> 30: import org.junit.jupiter.api.Assertions; > > Note: This mixes JUnit 4 with JUnit 5 API. > AFAIK, this is nothing we want, so it is better to use the already imported > `assertEquals` (from JUnit 4) below. right, I've changed this to JUnit 4 and removed the JUnit 5 import. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1489#discussion_r1654195502
