This might be controversial. I am proposing to remove the Gradle integration in 
the Eclipse config files.

Problem
=======
Eclipse Gradle integration (Buildship) cannot import the OpenJFX build.gradle 
cleanly. Every time the project is imported into a new workspace (or re-opened 
after being closed) it executes Gradle, creates and modifies a number of 
Eclipse .project and .classpath files, all of which need to be reverted for 
Eclipse workspace to become usable again.

Solution
======
Remove Gradle nature from the Eclipse project files. This change only affects 
Eclipse config files and does not impact build.gradle or other IDEs.

Advantages
=========
1. The multiple nested projects in the repo will get imported cleanly on the 
first attempt, will not require additional steps to clear the Buildship changes.
2. completely removes the dependency on the Eclipse Buildship and its 
idiosyncrasies.

NOTES:
- even though the reverse was done for IntelliJ, but its gradle import still 
does not import tests cleanly, see 
[JDK-8223373](https://bugs.openjdk.org/browse/JDK-8223373)
- this improvement contradicts 
[JDK-8223374](https://bugs.openjdk.org/browse/JDK-8223374) as without Eclipse 
files in the repo, it will be impossible to use Eclipse in a meaningful way 
without the fully functional Buildship support, and that is a big IF.
- once integrated, Eclipse users would only need to re-import the main project 
with 'search for nested projects' enabled

-------------

Commit messages:
 - Merge branch 'master' into 8335218.eclipse
 - remove gradle
 - Merge branch 'master' into ag.eclipse.plain
 - removed gradle from eclipse projects

Changes: https://git.openjdk.org/jfx/pull/1491/files
  Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1491&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8335218
  Stats: 26 lines in 4 files changed: 0 ins; 26 del; 0 mod
  Patch: https://git.openjdk.org/jfx/pull/1491.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1491/head:pull/1491

PR: https://git.openjdk.org/jfx/pull/1491

Reply via email to