On Wed, 3 Jul 2024 15:05:50 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> tests/system/src/test/java/test/com/sun/prism/impl/NGNodeDirtyFlagTest.java 
>> line 68:
>> 
>>> 66:             root = new StackPane();
>>> 67:             primaryStage.setScene(new Scene(root, 500, 400));
>>> 68: 
>> 
>> Please add `primaryStage.setAlwaysOnTop(true);` call here, without it the 
>> test can fail fail intermittently if the test window gets behind any other 
>> window.
>
> Also, we generally recommend an undecorated stage for any tests that do a 
> screen capture.

The test now extends the ``VisualTestBase`` and therefore the stage is now 
alwaysOnTop and undecorated.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1451#discussion_r1664467625

Reply via email to