On Fri, 5 Jul 2024 17:11:54 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add many more unit tests for Tooltip
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TooltipTest.java
> line 657:
>
>> 655: // Style: .tooltip { -fx-show-delay: 200ms; }
>> 656: stageLoader.getStage().getScene().getStylesheets()
>> 657:
>> .add("data:base64,LnRvb2x0aXAgeyAtZngtc2hvdy1kZWxheTogMjAwbXM7IH0=");
>
> this is clever. can we generate the base64-encoded string on the fly?
> something along the lines
>
>
> return "data:text/css;base64," + Base64.getEncoder().encodeToString(b);
>
>
> (here and elsewhere?)
Thought about this well, didn't test yet
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1394#discussion_r1667350521
