On Tue, 9 Jul 2024 09:09:30 GMT, Johan Vos <j...@openjdk.org> wrote:

>> tests/system/src/test/java/test/com/sun/javafx/tk/quantum/SystemMenuBarTest.java
>>  line 287:
>> 
>>> 285: 
>>> 286:     @Test
>>> 287:     public void testJDK8309935() {
>> 
>> minor: Not sure what our policies are, but I find test names like this 
>> pretty useless, perhaps a short indication what this is doing?
>
> It is a good question. We don't have a consistent approach yet. I personally 
> like the link to the JBS issue as that has (or should have) all info. I added 
> a short indication, but the real info should be on the issue, imho.
> (this is something we should discuss on the mailing list)

I see that you added a comment now, that helps a lot, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1283#discussion_r1670352389

Reply via email to