On Tue, 9 Jul 2024 07:23:09 GMT, Ambarish Rapte <[email protected]> wrote:
>> The parameter "offset" is not validated in the 2 native methods getRGBImpl()
>> and setRGBImpl() of com.sun.pisces.AbstractSurface (in JAbstractSurface.c).
>> The PR adds the "offset < 0" check to both the methods.
>
> Ambarish Rapte has updated the pull request incrementally with one additional
> commit since the last revision:
>
> const vars
lgtm
modules/javafx.graphics/src/main/native-prism-sw/JAbstractSurface.c line 70:
> 68: jint x, jint y, jint width, jint height) {
> 69: const jint dstX = 0;
> 70: const jint dstY = 0;
if it were up to me, I'd remove these as part of this PR.
-------------
Marked as reviewed by angorya (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1497#pullrequestreview-2166934862
PR Review Comment: https://git.openjdk.org/jfx/pull/1497#discussion_r1670898504
