On Thu, 27 Jun 2024 13:43:37 GMT, Marius Hanl <mh...@openjdk.org> wrote:

>> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog` 
>> is broken when `sizeToScene()` was called before or after.
>> 
>> The approach here is to ignore the `sizeToScene()` request when the `Stage` 
>> is maximized or set to fullscreen. 
>> Otherwise the Window Manager of the OS will be confused and you will get 
>> weird flickering or wrong Window buttons (e.g. on Windows, the 'Maximize' 
>> button still shows the 'Restore' Icon, while we already resized the `Stage` 
>> to not be maximized).
>
> Marius Hanl has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   add delta for assertStageScreenBounds

I'm not sure how we missed this in testing, but the full screen tests fail on 
Ubuntu 22.04 because a full screen window can be larger than the visual bounds. 
I started seeing nightly headful test failures after this was integrated, but 
didn't have time to look at it until now. I filed 
[JDK-8336272](https://bugs.openjdk.org/browse/JDK-8336272) to fix the test.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1382#issuecomment-2224028466

Reply via email to