On Wed, 10 Jul 2024 15:14:42 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> my comment was to avoid replicating "data:base64,", and with that, it is not >> base64 anymore, but base-64-encoded url. >> >> the best place for this method is probably in some utility class so it can >> be reused. > >> my comment was to avoid replicating "data:base64,", and with that, it is not >> base64 anymore, but base-64-encoded url. > > I see. > >> the best place for this method is probably in some utility class so it can >> be reused. > > Definitely, but let's do that in a follow-up testbug (and update the other > test you pointed to at the same time). created https://bugs.openjdk.org/browse/JDK-8336334 ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1394#discussion_r1676419856
