On Fri, 19 Jul 2024 01:11:24 GMT, Jay Bhaskar <jbhas...@openjdk.org> wrote:

> Issue : CookieEnable method returns false when WebView url is empty
> Solution: Use a dummy file URI in WebView before testing cookie.

I confirm that the test now passes. I left one comment on the html file you 
added and will reapprove if you change it.

modules/javafx.web/src/test/resources/test/html/cookie.html line 4:

> 2: <html>
> 3: <head>
> 4:     <meta http-equiv="Refresh" content="100; URL=ipsum.html" />

The redirect to another html file seems unnecessary. Is there a reason you 
added it? If I locally remove the `<head>...</head>` block the still passes.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1513#pullrequestreview-2188920799
PR Review Comment: https://git.openjdk.org/jfx/pull/1513#discussion_r1684800629

Reply via email to