On Mon, 22 Jul 2024 14:14:28 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>>> Another question: do we want to go through all the cases of >>> Scene/SubScene/Parent/Region user agent style sheet, for completeness sake, >>> or would that be a different test file? >> >> In my opinion, this does seem a bit of out of scope for this change. It >> would not add any new coverage to the code that was changed. Also the >> origin of the user agent stylesheet is not a factor in the resolution of >> lookups. The user agent stylesheets, their replacement (via Scene/Subscene) >> or addition (via Region) should (already?) be tested elsewhere. > > I added a few cases where user agent is `null`. I've not added all > combinations as that would lead to 20-30 extra cases that add little of > value. If I already verified that INLINE will override the lower priority > sources individually, then it's safe to say that all possible other > combinations of those lower priority sources will also get overridden. I still think there is a value in providing exhaustive coverage, especially since the number of combination is relatively low. The added value, for instance, is to guard against regressions introduced by other people. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1503#discussion_r1686688812
