On Sat, 16 Nov 2024 15:09:40 GMT, Kevin Rushforth <[email protected]> wrote:
>> Ambarish Rapte has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into exp-suffix
>> - 8343196: Add build property to identify experimental builds of JavaFX
>
> build.gradle line 705:
>
>> 703: } else {
>> 704: relSuffix = jfxExperimentalReleaseSuffix != "" ?
>> 705: jfxExperimentalReleaseSuffix : jfxReleaseSuffix;
>
> One thought I had: we might also want to set `relOpt = "-${buildTimestamp}"`
> here like we do for internal builds so we always see a time stamp for
> experimental builds. What do you think?
I agree with that. It is often useful to have timestamp info in the builds
during development.
I know I'm a broken record on this topic, but if possible, it would be great if
(parts of) this logic can be moved into a separate file in order to make the
build.gradle smaller and more readable. I'm not insisting on this for this PR,
but I think it is worth thinking about this whenever changes to build.gradle
are made.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1637#discussion_r1845179006
