On Wed, 15 Jan 2025 19:22:50 GMT, Jose Pereda <[email protected]> wrote:
>> Marius Hanl has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new commit since the last revision:
>>
>> 8185887: TableRowSkinBase fails to correctly virtualize cells in
>> horizontal direction
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java
> line 221:
>
>> 219: /** {@inheritDoc} */
>> 220: @Override protected void layoutChildren(double x, double y, double
>> w, double h) {
>> 221: Node disclosureNode = getDisclosureNode();
>
> I take these changes (related to disclosure node) are not really related to
> the initial issue of this PR, and I wonder if
> [JDK-8346824](https://bugs.openjdk.org/browse/JDK-8346824) should not be part
> of this PR. Do the added tests verify these changes and if the issue is
> solved with them?
This is more likely an 'accidential' fix. I changed this code because the code
in the super class changed (e.g. `updateCells` and `updateChildren`). So while
I see your point, if possible I would not try to cherrypick this out (if even
possible) and keep it in here.
Good point, I will check if I can write a test for it.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1644#discussion_r1918362810
