On Mon, 24 Mar 2025 14:23:39 GMT, Ziad El Midaoui <[email protected]>
wrote:
>> Added multi line prompt support for TextArea this will provide the ability
>> to have multiple lines in textArea as expected,
>> Also fixed tests to meet the new changes
>
> Ziad El Midaoui has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Minor changes
modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java
line 33:
> 31: import javafx.beans.binding.ObjectBinding;
> 32: import javafx.beans.binding.StringBinding;
> 33: import javafx.beans.binding.Bindings;
unused import can be removed
modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextFieldSkin.java
line 737:
> 735:
> 736:
> promptNode.textProperty().bind(getSkinnable().promptTextProperty());
> 737:
> promptNode.textProperty().bind(getSkinnable().promptTextProperty().map(s ->
> s.replace("\n", "")));
code in line 736 is not needed (we all missed that)
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1716#discussion_r2010589070
PR Review Comment: https://git.openjdk.org/jfx/pull/1716#discussion_r2010583781
