On Thu, 15 May 2025 09:26:42 GMT, Gopal Pattnaik <[email protected]> wrote:
> On loading of the reported URL, it looks like a browser version check is made
> (like Safari version, Chrome version etc). At present the browser version is
> not part of the user agent string we are using for JavaFX Webview
>
> Solution:
> Added a version string in the user agent similar to Safari.
>
> Verification:
> The test program attached to the JBS passes with this change.
This looks reasonable. Please update the description with what testing you have
done on various websites.
I left one clarifying suggestion inline.
Reviewers: @jaybhaskar @kevinrushforth
Reviewers: @jaybhaskar @kevinrushforth
build.gradle line 623:
> 621: defineProperty("PROMOTED_BUILD_NUMBER", "0")
> 622: defineProperty("MILESTONE_FCS", "false")
> 623: defineProperty("WEBVIEW_VERSION", "18.4")
Can you separate this from the previous 4 "Husdon" definitions by a blank line
and also add a comment?
build.gradle line 4023:
> 4021: targetCpuBitDepthSwitch = "--32-bit"
> 4022: }
> 4023: cmakeArgs += "
> -DWEBVIEW_RELEASE_VERSION=${WEBVIEW_VERSION}"
Since this is a browser version, as noted in the PR Description, I recommend
changing this variable name here and in the below files to
`WEBVIEW_BROWSER_VERSION`.
-------------
PR Review: https://git.openjdk.org/jfx/pull/1808#pullrequestreview-2843526871
PR Comment: https://git.openjdk.org/jfx/pull/1808#issuecomment-2883667277
PR Comment: https://git.openjdk.org/jfx/pull/1808#issuecomment-2886618250
PR Review Comment: https://git.openjdk.org/jfx/pull/1808#discussion_r2091112101
PR Review Comment: https://git.openjdk.org/jfx/pull/1808#discussion_r2091070643
