On Thu, 26 Jun 2025 14:18:53 GMT, Lukasz Kostyra <lkost...@openjdk.org> wrote:
> These PipeWire declarations have been just moved here from the original > header. Is this move necessary? It is about clang 17 warning, it was [fixed](https://github.com/openjdk/jdk/pull/23236) on the jdk side. I am trying to keep the code similar between OpenJDK and OpenJFX, so I brought this fix here to make maintenance easier. > Also (a general thought towards past implementation, not just to your change) > I think we should not define those manually at all. There are PipeWire > headers defining those that we should include (and I believe we do already > include some in screencast_pipewire.h The point is basically the same: ease of maintenance between OpenJDK and OpenJFX. OpenJDK can also be built on very old Linux distributions that lack the necessary headers. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1834#discussion_r2169505361
