On Thu, 24 Jul 2025 21:28:43 GMT, Kevin Rushforth <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix resizable state of macOS window
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.m line 1165:
>
>> 1163: {
>> 1164: GlassWindow *window = getGlassWindow(env, jPtr);
>> 1165: [window _setResizable:jResizable];
>
> I presume you removed the `performSelectorOnMainThread` because the calling
> method always calls this on the main thread?
Yes, this is a call that always happens on the FX thread as a result of calling
`javafx.stage.Window.show()`. This is verified just a few lines earlier with
`GLASS_ASSERT_MAIN_JAVA_THREAD` (that's always been there, I didn't add it).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1831#discussion_r2229665362
