On Wed, 30 Jul 2025 22:46:32 GMT, Martin Fox <m...@openjdk.org> wrote:
>> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 60 commits: >> >> - Simplify notify_fullscreen >> - Merge branch 'master' into 8354943 >> - Remove repaint call (8351867 is fixed) >> - Merge branch 'master' into 8354943 >> - Remove unused const >> - Remove wrong call to enter_fullscreen >> - Review changes >> - Use process_expose >> - Min / Max size improvements >> - Invalidate view size on new view >> - ... and 50 more: https://git.openjdk.org/jfx/compare/bc433da8...d1842395 > > tests/system/src/test/java/test/robot/javafx/stage/StageOwnershipTest.java > line 184: > >> 182: @ParameterizedTest(name = PARAMETERIZED_TEST_DISPLAY) >> 183: @MethodSource("getTestsParams") >> 184: void openingModalChildStageWhileMaximizedShouldHaveFocus(StageStyle >> stageStyle, Modality modality) > > This test includes "Focus" in the title but you don't seem to be asserting > that the expected window has focus. This is true for several of the other > tests in this file. Fixed the method naming > tests/system/src/test/java/test/robot/javafx/stage/StageOwnershipTest.java > line 287: > >> 285: () -> { >> 286: assertTrue(stage0.isIconified()); >> 287: assertColorDoesNotEqual(COLOR0, stage0); > > Are these the correct tests? If all stages are iconified you'll be picking up > random colors from the desktop. One of those random colors might just match > one of the color constants here. I fixed the method name, but I think the test is correct - it does get a random color, but it tests for no match. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2264639868 PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2264640207
