On Wed, 3 Sep 2025 11:21:24 GMT, Hima Bindu Meda <[email protected]> wrote:
> Updated icu to v77.1. Verified build on windows, mac and linux. Sanity
> testing looks fine. No issues seen.
Looks good with one suggested change.
modules/javafx.web/src/main/native/Source/ThirdParty/icu/source/common/unicode/platform.h
line 740:
> 738: # else
> 739: // conformant C11
> 740: # define U_HAVE_CHAR16_T 0
Suggestion:
/* Commented out for JavaFX
// conformant C11
# define U_HAVE_CHAR16_T 1
*/
// JavaFX: We cannot define U_HAVE_CHAR16_T
# define U_HAVE_CHAR16_T 0
Since this alters upstream code, I recommend restoring line 740 from upstream
(which sets `U_HAVE_CHAR16_T ` to 1), commenting it out, and adding a
JavaFX-specific comment like the one I suggested above.
-------------
PR Review: https://git.openjdk.org/jfx/pull/1882#pullrequestreview-3203239751
PR Review Comment: https://git.openjdk.org/jfx/pull/1882#discussion_r2334737339
